Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 )
Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I agree with fixeria that we should tend to use MISC_Helpers.f_shutdown when > possible. It should be said that I definitely don't want to force using `f_shutdown` everywhere, especially using it to set the verdict (because we have `setverdict` for that). My concern was that doing `mtc.stop` sometimes causes DTEs due to port messages arriving on unconnected ports, and doing `all component.stop` in this function is supposed to avoid this. But in this specific case `self != mtc`, so as Oliver said it evaluates to `mtc.stop` anyway... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab Gerrit-Change-Number: 33630 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 07 Jul 2023 13:09:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
