Attention is currently required from: laforge, fixeria.

Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/32762 )

Change subject: transceiver: pass cfg struct instead of args
......................................................................


Patch Set 3:

(1 comment)

File Transceiver52M/device/lms/LMSDevice.h:

https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/ca0ff00c_6d94891a
PS3, Line 110:     LMSDevice(InterfaceType iface, const struct trx_cfg *cfg);
> AFAICT, the usual approach we take in such situations is to reformat once in 
> one patch, and then per […]
The only part of osmotrx that follow any style is the ms subdirectory, 
everythting else is 15 years of random baggage.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32762
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b
Gerrit-Change-Number: 32762
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 07 Jul 2023 16:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to