Attention is currently required from: laforge, pespin, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32762 )
Change subject: transceiver: pass cfg struct instead of args ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > I find it difficult to review this patch because afaict there's several steps > merged int one: […] I don't know what to split here because the patch does only one thing, and that is replacing the dozen args with the cfg struct for the devsice classes and the dev base class,radiodevice, which makes it really easy to track the usage of the config args because they don't get mangled and copied five times or pushed into vectors just to be passed down two layers. Of course open() does not require any args because the full config is already known at construction time. the dev args string is a string and ensuring it always is a string and not a dangling pointer by properly initializing it as a string is required to be able to just use it. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b Gerrit-Change-Number: 32762 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 27 Jul 2023 14:19:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
