Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 )
Change subject: stream (cosmetic): Fix osmo_panic log fmts ...................................................................... Patch Set 8: Code-Review+1 (3 comments) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/82787bb9_6a043b1f PS6, Line 615: cli->state); > there's also the __func__ or __FUNCTION__ macro that could be used here. […] Done File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/1a6dd28c_88af7da5 PS8, Line 613: osmo_panic("osmo_stream_cli_write_cb() called with unexpected state %d\n", cli->state); why the line wrap here ? having this in one line certainly doesn't exceed the permitted line length. https://gerrit.osmocom.org/c/libosmo-netif/+/33206/comment/3ed57ea9_670768c8 PS8, Line 633: } why the line wrap here ? having this in one line certainly doesn't exceed the permitted line length. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:06:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
