Attention is currently required from: arehbein, laforge.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )

Change subject: stream: Add server-side (segmentation) support for IPA
......................................................................


Patch Set 10:

(3 comments)

File include/osmocom/netif/ipa.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/6aceb681_84ddd290
PS10, Line 6: #include <osmocom/netif/stream.h>
Not sure why ipa.h needs this tbh


https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/571e4bde_027e1ba4
PS10, Line 46: int osmo_ipa_segmentation_cb(struct msgb *msg);
This belongs in the previous commit


File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/c6320ef3_3244ab64
PS10, Line 39: #include <osmocom/gsm/ipa.h>
Not needed.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c
Gerrit-Change-Number: 33197
Gerrit-PatchSet: 10
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Mon, 10 Jul 2023 14:45:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to