laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33699 )
Change subject: Introduce concept of CardProfileAddon ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/33699/comment/f6ccdb67_83ccdcb8 PS3, Line 1310: for addon_cls in self.profile.addons: this must not happen in the constructor, as pySim-trace also uses RuntimeState. So nothing here may need to talk to the card... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5866590b6d48f85eb889c9b1b8ab27936d2378b9 Gerrit-Change-Number: 33699 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 17:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
