Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33699 )
Change subject: Introduce concept of CardProfileAddon ...................................................................... Patch Set 4: Code-Review-1 (3 comments) This change is ready for review. File pySim/cdma_ruim.py: https://gerrit.osmocom.org/c/pysim/+/33699/comment/985fc7d2_129e57cf PS4, Line 196: can be found on either classic GSM SIM or on UICC to support GSM-R > I am guessing you meant R-UIM here, not GSM-R? `-ETOOMANYRRRRR` ;) Done File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/33699/comment/018d1ec9_30787e0f PS3, Line 1310: for addon_cls in self.profile.addons: > this must not happen in the constructor, as pySim-trace also uses > RuntimeState. […] this actually is not true. the DummySimLink will return SW 9000 to all APDUs and hence all probes will be succesful. This means the pySim-trace will get all add-ons enabled, which is a good idea since we have no idea what kind of files etc. will appear in the trace. File pySim/profile.py: https://gerrit.osmocom.org/c/pysim/+/33699/comment/19cb5071_dccbd696 PS4, Line 194: probe > Right. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5866590b6d48f85eb889c9b1b8ab27936d2378b9 Gerrit-Change-Number: 33699 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 19:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
