Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33704 )
Change subject: cdma_ruim: Fix unit tests and actually enable them ...................................................................... Patch Set 1: (1 comment) File pySim/cdma_ruim.py: https://gerrit.osmocom.org/c/pysim/+/33704/comment/d2e191d4_cb34b075 PS1, Line 136: HexAdapter > we *always* want Hex, as bytes cannot be serialized to JSON. […] Then we should be using `HexAdapter` for the `rfu` field too, because it's also `bytes`? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icdf4621eb68d05a4948ae9efeb81a007d48e1bb7 Gerrit-Change-Number: 33704 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 19:41:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
