laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/33704
)
Change subject: cdma_ruim: Fix unit tests and actually enable them
......................................................................
cdma_ruim: Fix unit tests and actually enable them
As pySim.cdma_ruim was not imported by test_files.py, the unit tests
were apparently never executed and hence didn't pass. Let's fix both
of those problems.
Change-Id: Icdf4621eb68d05a4948ae9efeb81a007d48e1bb7
---
M pySim/cdma_ruim.py
M tests/test_files.py
2 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/cdma_ruim.py b/pySim/cdma_ruim.py
index 3fab558..8b66490 100644
--- a/pySim/cdma_ruim.py
+++ b/pySim/cdma_ruim.py
@@ -91,7 +91,7 @@
_test_de_encode = [
(
"010801536b796c696e6b204e57ffffffffffffffffffffffffffffffffffffffffffff",
- { 'rfu0' : 0, 'show_in_hsa' : True, 'rfu2' : 0,
+ { 'rfu1' : 0, 'show_in_hsa' : True, 'rfu2' : 0,
'char_encoding' : 8, 'lang_ind' : 1, 'spn' : 'Skylink NW' } ),
]
@@ -133,9 +133,9 @@
# Byte 1: Display Condition
'ms_operation_mode'/Enum(Byte, self.OP_MODE),
# Bytes 2-3: Additional information
- 'additional_info'/Bytes(2),
+ 'additional_info'/HexAdapter(Bytes(2)),
# Bytes 4..: RFU
- 'rfu'/GreedyBytesRFU,
+ 'rfu'/HexAdapter(GreedyBytesRFU),
)
diff --git a/tests/test_files.py b/tests/test_files.py
index 3fb1062..fe520fb 100755
--- a/tests/test_files.py
+++ b/tests/test_files.py
@@ -29,6 +29,7 @@
import pySim.ts_51_011
import pySim.sysmocom_sja2
import pySim.gsm_r
+import pySim.cdma_ruim
def get_qualified_name(c):
"""return the qualified (by module) name of a class."""
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33704
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icdf4621eb68d05a4948ae9efeb81a007d48e1bb7
Gerrit-Change-Number: 33704
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged
