Attention is currently required from: laforge, fixeria.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/33591 )

Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300
......................................................................


Patch Set 3:

(2 comments)

File src/libmsc/csd_bs.c:

https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/547cf694_12cd611d
PS1, Line 187: GSM0808_DATA_HALF_LM
> I agree
Done


https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/32f4f86e_aaf0640c
PS1, Line 196: GSM0808_DATA_FULL_BM
> technically it is true, one can carry those rates over TCH/H. […]
I've kept them at GSM0808_DATA_FULL_BM and extended the commit message to note 
that FULL_PREF was considered.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33591
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0
Gerrit-Change-Number: 33591
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 12 Jul 2023 09:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to