Attention is currently required from: osmith, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33591 )
Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300 ...................................................................... Patch Set 3: (1 comment) File src/libmsc/csd_bs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/95e87e88_e812cc0a PS1, Line 196: GSM0808_DATA_FULL_BM > technically it is true, one can carry those rates over TCH/H. I'm not sure > how good a policy decision it is, given that TCH/F provides so much more > redundancy and hence robustness... IIUC the idea behind `GSM0808_DATA_FULL_PREF` is that we allocate a TCH/F whenever possible, or a TCH/H if no TCH/F is available. If my understanding is correct, then giving a TCH/H is still better than rejecting a connection... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0 Gerrit-Change-Number: 33591 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 12 Jul 2023 16:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
