Attention is currently required from: jolly, pespin, dexter.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/33297 )

Change subject: ASCI: Add Notification CHannel (NCH) support
......................................................................


Patch Set 6:

(1 comment)

File src/common/bts.c:

https://gerrit.osmocom.org/c/osmo-bts/+/33297/comment/60e94860_8e918a99
PS6, Line 726: int is_nch_res, int is_ag_res
Do we expect/permit any combinations of these two flags?
If not, then let's please use an enum here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33297
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I82fdaba3faaced76267a99ae14a5458a1b41fdaa
Gerrit-Change-Number: 33297
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Mon, 17 Jul 2023 13:44:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to