Attention is currently required from: jolly, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33297 )
Change subject: ASCI: Add Notification CHannel (NCH) support ...................................................................... Patch Set 7: (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/33297/comment/7234bd19_28c92ce3 PS6, Line 726: int is_nch_res, int is_ag_res > If is_nch_res is set, the message to be sent is an NCH message on NCH. […] Thanks for explaining. Still, IMO an enum would be a better fit here: ``` CCCH_MSGT_NCH, CCCH_MSGT_PCH, CCCH_MSGT_AGCH, ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I82fdaba3faaced76267a99ae14a5458a1b41fdaa Gerrit-Change-Number: 33297 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Wed, 19 Jul 2023 17:43:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
