Attention is currently required from: dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33963 )
Change subject: tests: add test script for pySim-trace
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
this is good for a very basic test, but *not raising an exception* is of course
a rather vague "pass criteria". I guess we have to think about what can be
done in terms of further result verification (in follow-up patches). A
low-hanging fruit would be to match the number of APDUs received.
One *could* match the console output (similar to our autotest unit-tests in the
osmo-{bts,bsc,msc,...} software. However, as we also know from there, every
minor whitespace or cosmetic change will then require updating of the test
results. Given that it should be simple to implement (famous last words), I
think it might be worth a shot to have an expected stdout/stderr text file
against we compare the pySim-trace output.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33963
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icfabfa7c59968021eef0399991bd05b92467d8d2
Gerrit-Change-Number: 33963
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Fri, 28 Jul 2023 09:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
