Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33963 )
Change subject: tests: add test script for pySim-trace ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > this is good for a very basic test, but *not raising an exception* is of > course a rather vague "pass […] I think matching the number of APDUs is a good idea. (Unfortunately I already spotted discrepancies between the number of packets shown in Wireshark and the number of APDUs we currently get - but the end looks good.) Comparing the output might be prone to produce false alarms from time to time. Fortunately the test does not need any special environment, so it should be easy to manage. I would say we should try it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icfabfa7c59968021eef0399991bd05b92467d8d2 Gerrit-Change-Number: 33963 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Fri, 28 Jul 2023 09:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
