Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 )
Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ...................................................................... Patch Set 2: (1 comment) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/c1f203c9_8cc7bc61 PS2, Line 68: inout charstring, CallParameters, ASCI_Event; > ... Sounds simple, but then also means that they need their own f_init* etc. > functions wrapping those of the components derived of to set up that port. Adding module-local f_init* etc. functions is not really needed if you derive a new component from an already existing component (using the `extends` keyword). For instance: ``` type component FooBarCT extends FooCT, BarCT { ... }; function f_foo() runs on FooCT { ... } ``` In this example function `f_foo` can not only be called from component `FooCT`, but also from component `FooBarCT`, because the later inherits all fields/ports from the former. So all `f_init*` functions and altsteps from module `MSC_Tests` would still be usable for `MSC_Tests_ASCI`, even if it derives its own `TestCT`. Furthermore, AFAICS, setting up the COORD ports currently needs to be done manually in each testcase spawning more than one child component. The `f_init*` functions are not involved in this process. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 Gerrit-Change-Number: 33979 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 11:48:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
