Attention is currently required from: laforge, fixeria, dexter.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33831 )
Change subject: requirements: add pyshark to requirements lists
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I found that at least setup. […]
pyshark could also be made an optional dependency like this:
```
try:
import pyshark
except ImportError:
pyshark = None
# … where it actually would get used:
if pyshark:
# …
```
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33831
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I885c7210aac3774a5f1f5201903ad2bff94c3120
Gerrit-Change-Number: 33831
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 02 Aug 2023 08:44:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment
