pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/34081 )
Change subject: stream_srv: Increase logging level of SCTP MSG_NOTIFICATION
lines
......................................................................
stream_srv: Increase logging level of SCTP MSG_NOTIFICATION lines
Those are events affecting the state of the link, so it makes sense to
have a higher level than debug.
Change-Id: I0ed84cc2effb71b6ef1f6efb3f8b663c602a5a31
---
M src/stream_srv.c
1 file changed, 22 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/81/34081/1
diff --git a/src/stream_srv.c b/src/stream_srv.c
index 554596d..c1d3739 100644
--- a/src/stream_srv.c
+++ b/src/stream_srv.c
@@ -845,33 +845,33 @@
msgb_sctp_stream(msg) = sinfo.sinfo_stream;
if (flags & MSG_NOTIFICATION) {
union sctp_notification *notif = (union sctp_notification
*)data;
- LOGP(DLINP, LOGL_DEBUG, "NOTIFICATION %u flags=0x%x\n",
notif->sn_header.sn_type, notif->sn_header.sn_flags);
+ LOGP(DLINP, LOGL_INFO, "NOTIFICATION %u flags=0x%x\n",
notif->sn_header.sn_type, notif->sn_header.sn_flags);
msgb_put(msg, sizeof(union sctp_notification));
msgb_sctp_msg_flags(msg) =
OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION;
switch (notif->sn_header.sn_type) {
case SCTP_ASSOC_CHANGE:
- LOGP(DLINP, LOGL_DEBUG, "===> ASSOC CHANGE:");
+ LOGP(DLINP, LOGL_INFO, "===> ASSOC CHANGE:");
switch (notif->sn_assoc_change.sac_state) {
case SCTP_COMM_UP:
- LOGPC(DLINP, LOGL_DEBUG, " UP\n");
+ LOGPC(DLINP, LOGL_INFO, " UP\n");
break;
case SCTP_COMM_LOST:
- LOGPC(DLINP, LOGL_DEBUG, " LOST\n");
+ LOGPC(DLINP, LOGL_INFO, " LOST\n");
/* Handle this like a regular disconnect */
return 0;
case SCTP_RESTART:
- LOGPC(DLINP, LOGL_DEBUG, " RESTART\n");
+ LOGPC(DLINP, LOGL_INFO, " RESTART\n");
break;
case SCTP_SHUTDOWN_COMP:
- LOGPC(DLINP, LOGL_DEBUG, " SHUTDOWN COMP\n");
+ LOGPC(DLINP, LOGL_INFO, " SHUTDOWN COMP\n");
break;
case SCTP_CANT_STR_ASSOC:
- LOGPC(DLINP, LOGL_DEBUG, " CANT STR ASSOC\n");
+ LOGPC(DLINP, LOGL_INFO, " CANT STR ASSOC\n");
break;
}
break;
case SCTP_SEND_FAILED:
- LOGP(DLINP, LOGL_DEBUG, "===> SEND FAILED\n");
+ LOGP(DLINP, LOGL_INFO, "===> SEND FAILED\n");
break;
case SCTP_PEER_ADDR_CHANGE:
{
@@ -879,14 +879,14 @@
struct sockaddr_storage sa =
notif->sn_paddr_change.spc_aaddr;
osmo_sockaddr_to_str_buf(addr_str, sizeof(addr_str),
(const struct osmo_sockaddr
*)&sa);
- LOGP(DLINP, LOGL_DEBUG, "===> PEER ADDR CHANGE: %s %s
err=%s\n",
+ LOGP(DLINP, LOGL_INFO, "===> PEER ADDR CHANGE: %s %s
err=%s\n",
addr_str,
osmo_sctp_paddr_chg_str(notif->sn_paddr_change.spc_state),
(notif->sn_paddr_change.spc_state ==
SCTP_ADDR_UNREACHABLE) ?
osmo_sctp_sn_error_str(notif->sn_paddr_change.spc_error) : "None");
}
break;
case SCTP_SHUTDOWN_EVENT:
- LOGP(DLINP, LOGL_DEBUG, "===> SHUTDOWN EVT\n");
+ LOGP(DLINP, LOGL_INFO, "===> SHUTDOWN EVT\n");
/* RFC6458 3.1.4: Any attempt to send more data will
cause sendmsg()
* to return with an ESHUTDOWN error. */
break;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34081
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I0ed84cc2effb71b6ef1f6efb3f8b663c602a5a31
Gerrit-Change-Number: 34081
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-MessageType: newchange
