Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34081 )
Change subject: stream_srv: Increase logging level of SCTP MSG_NOTIFICATION lines ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34081/comment/e91b56b5_005c0607 PS1, Line 834: static int _sctp_recvmsg_wrapper(int fd, struct msgb *msg) the problem I always had with this function that it doesn't differentiate the log level based on the kind of event/notification. For example, I would say "SEND FAILED or "SHUTDOWN" are even worth NOTICE, but given that we use LOGPC we cannot change the log level of the prefix printed in the LOGP. Changing everything to INFO is the right direction, of course. One might argue everything except "UP" is NOTICE. But then it's awkward if you have level notice set and you see only the disconencts but never the new connects... -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0ed84cc2effb71b6ef1f6efb3f8b663c602a5a31 Gerrit-Change-Number: 34081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
