Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 )
Change subject: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
in general, yes - but at the moment the patch you're referring-to has not yet
been merged. and even after it is merged, nothing is enforcing the user to link
against a recent enought libosmo-netif. This might easily lead to silent error
behaviour.
Also, at the very least I would expect a TODO-RELEASE update stating that an
updated libosmo-netif is required.
To me, this kind of change *might* even rectify bumping the libversion of
libosmo-netif right now and make this patch depend on it.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34089
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If3d78b636e8e224aa9c8597d0b242e29d3e3c84e
Gerrit-Change-Number: 34089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 09 Aug 2023 15:02:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
