Attention is currently required from: laforge, pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 )
Change subject: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs
......................................................................
Patch Set 1:
(2 comments)
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/36a57edf_91cc416e
PS1, Line 1951: rc = 0;
What if rc == -EAGAIN, do you want it to be set to 0? (probably, but just to be
sure)
https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/bb41784e_910b250e
PS1, Line 1954: if (rc < 0) {
why not if (rc <= 0) {?
Same for xua_srv_conn_cb
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34089
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If3d78b636e8e224aa9c8597d0b242e29d3e3c84e
Gerrit-Change-Number: 34089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 21 Aug 2023 09:47:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
