Attention is currently required from: laforge, pespin, fixeria.

arehbein has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/33201 )

Change subject: stream: Add and use IPA send function
......................................................................


Patch Set 17:

(1 comment)

File tests/stream/stream_test.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/df2431de_6f1d4080
PS14, Line 397:         IPAC_MSG_IDREQ_PAYLOAD_INITIALIZER
> why did this change here? unrelated?
I wouldn't call it unrelated. I added the def 
`IPAC_MSG_IDREQ_PAYLOAD_INITIALIZER` to avoid replicating the same sequence of 
identifiers/commas/whitespace multiple times, not using this macro here in the 
same way would have been inconsistent.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 17
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 23 Aug 2023 16:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to