Attention is currently required from: arehbein, fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email )

Change subject: stream: Add and use IPA send function
......................................................................


Patch Set 20: Code-Review+1

(1 comment)

File src/ipa.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/98abd5de_d91c8df1
PS20, Line 456: osmo_ipa_stream_srv_send
> TBH, I don't really see the benefits of having this API. […]
I agree with fixeria here, I already shared my concerns about this kind of API 
;)



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 20
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 02 Oct 2023 09:21:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to