Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 )
Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Why not have a global variable incrementing with each new conn instead of taking it from fd? That would improve a lot the equal distribution. Depending on how fds are allocated they can end up with most ASPs using the same SLS. File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34264/comment/c12cd83b_358ffdf4 PS1, Line 295: * \param[in] msg received message buffer. Callee takes ownership! missing new param documentation -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:55:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
