Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 )
Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why not have a global variable incrementing with each new conn instead of > taking it from fd? That wo […] I am not sure a global variable would lead to better distribution, given that that would be one range split over all AS. So if you have an even number of ASs with an even number of ASPs and a fairly determinstic bring-up after restart / link-failure, you might end up having all of the ASPs within one AS in the same bucket. If you really wanted to do better, you'd need a per-AS variable, not a global one. And this would break both ABI + API (due to all related structs being public) and I thought it's not worth going there *just* for that. Chances are high that this patch improves the situation significantly. If it's still creating problems to users, we can always improve later. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 01 Sep 2023 08:26:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
