Patch Set 2: (3 comments)
https://gerrit.osmocom.org/#/c/5618/2//COMMIT_MSG Commit Message: Line 13: Remove old libdbi versions and keep/apply the malloc patch Thanks, I actually forgot to check if the malloc patch was still required or if you removed it (it still necessary, it's applied in master but not for 0.9). https://gerrit.osmocom.org/#/c/5618/2/recipes-misc/libdbi/files/fix-0.9.0-compile.patch File recipes-misc/libdbi/files/fix-0.9.0-compile.patch: Line 8: + SQLITE3_LIBS=-lsqlite3 As I stated in the previous patch version, I'd prefer having 2 separate patches for the 2 chunks in this patch file. This change in acinclude.m4 is already applied in current master of libdbi and the other one is some specific hack to allow compilation for now which should be properly in upstream (perhaps by someone else). https://gerrit.osmocom.org/#/c/5618/2/recipes-misc/libdbi/libdbi-drivers_0.9.0.bb File recipes-misc/libdbi/libdbi-drivers_0.9.0.bb: Line 9: SRC_URI += "file://memory-corruption-fixes.patch" Better use something like: SRC_URI += "file://fix-0.9.0-compile.patch \ file://memory-corruption-fixes.patch \ " -- To view, visit https://gerrit.osmocom.org/5618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4319c595a1ccb20c87d86c1ab1e58e95da34d7b Gerrit-PatchSet: 2 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-HasComments: Yes
