Patch Set 2: (4 comments)
https://gerrit.osmocom.org/#/c/5618/1/recipes-misc/libdbi/files/fix-0.9.0-compile.patch File recipes-misc/libdbi/files/fix-0.9.0-compile.patch: Line 8: + SQLITE3_LIBS=-lsqlite3 > Please provide somewhere a reference explaining that this is a backport com Ha, I didn't even know they were using git and the issue was fixed upstream! I just saw the sf project page and downloaded the 0.9.0 releases. Line 19: +SUBDIRS = drivers @docs_subdirs@ > Why is this needed? why are the tests failing? I see no reference to this i Compilation of tests are failing that were added after 0.8.3-1. It seems they are using cgreen (whatever that is) and building that fails. https://gerrit.osmocom.org/#/c/5618/2/recipes-misc/libdbi/files/fix-0.9.0-compile.patch File recipes-misc/libdbi/files/fix-0.9.0-compile.patch: Line 8: + SQLITE3_LIBS=-lsqlite3 > As I stated in the previous patch version, I'd prefer having 2 separate pat Done https://gerrit.osmocom.org/#/c/5618/2/recipes-misc/libdbi/libdbi-drivers_0.9.0.bb File recipes-misc/libdbi/libdbi-drivers_0.9.0.bb: Line 9: SRC_URI += "file://memory-corruption-fixes.patch" > Better use something like: Done -- To view, visit https://gerrit.osmocom.org/5618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4319c595a1ccb20c87d86c1ab1e58e95da34d7b Gerrit-PatchSet: 2 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-HasComments: Yes
