Attention is currently required from: arehbein, fixeria, osmith, pespin.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email )

Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................


Patch Set 21:

(1 comment)

Patchset:

PS21:
> I guess printing the timestamp infront of the log should just be removed? 
> from a quick glance this s […]
I just retriggered jenkins and it succeeds again...
The tests uses osmo's gettimeofday_override functionality so it shouldn't cause 
these weird changes due to (wall clock) time delays. It's counting main loop 
iterations and the only way a mismatch could happen here (that I can think of) 
is if either the sending fd wasn't writable after enqueuing the msg or the 
receiving fd didn't become readable directly after the write.

So it's definitely worrying that we don't know the cause for this issue, but 
since nobody can reproduce it right now I'd say we continue with this patch 
(with timestamps) and see if it resurfaces.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 21
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 07 Sep 2023 14:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: arehbein <[email protected]>
Comment-In-Reply-To: daniel <[email protected]>
Gerrit-MessageType: comment

Reply via email to