Attention is currently required from: Hoernchen.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/34462?usp=email )

Change subject: ms: adjust ts advance
......................................................................


Patch Set 1:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-trx/+/34462/comment/cdbd0fd9_2e4a10fe
PS1, Line 15: The mobile app does not care, and will happily work even with 
fn+3.
you mean tn+3 here?


Patchset:

PS1:
So if I understand correctly this adds a let's say ~0.5 fn-advance? aka 
advances 3 TN the uplink from the downlink?

That may pose a problem if a TBF is changed from let's say TN7 to TN2, we may 
work incorrectly there due to 1 FN in upper layers, but I guess we can live 
with that for now.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34462?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I46b3ea6b0094026bd50709739df464438f9e54c4
Gerrit-Change-Number: 34462
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Comment-Date: Wed, 20 Sep 2023 14:04:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to