Attention is currently required from: pespin.

Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/34462?usp=email )

Change subject: ms: adjust ts advance
......................................................................


Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-trx/+/34462/comment/343d85ff_51c206e8
PS1, Line 15: The mobile app does not care, and will happily work even with 
fn+3.
> you mean tn+3 here?
no, actual frame advance, 3 frames in advance.


Patchset:

PS1:
> So if I understand correctly this adds a let's say ~0. […]
well this is my attempt to get your gprs side to give me tx bursts much 
earlier, because right now they arrive very late. 2ts advance just is a value 
that appears to "work", while 1fn breaks it.

I need tx bursts as soon as possible, and I'm currently getting bursts 0 ts in 
advance, with only the rx/tx offset of 3ts so save me, and if those bursts are 
just slightly delayed it's too late.


File Transceiver52M/ms/ms_upper.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/34462/comment/a3dfff55_0e1bc47b
PS1, Line 261:  burstTime.incTN(2);
> just to make sure, incTN(2) on FN=X TN=7 ends up with FN=X+1 TN=1, right?
yes, that is what the magic gsmtime class does.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34462?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I46b3ea6b0094026bd50709739df464438f9e54c4
Gerrit-Change-Number: 34462
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ew...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Sep 2023 14:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to