Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34471?usp=email )
Change subject: abis_nm: delay configure_loop() until NM_MT_SW_ACTIVATED_REP ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34471/comment/1fba5103_49466005 PS1, Line 116: /* nanoBTS only: delay until SW Activated Report is received */ maybe add in all the comments like this one that this is donde in order to obtain de object version before transmitting get/set attr. Otherwise readers don't understand why this is needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3953a5e41eb27165f9ff203cac7447ee9d311abf Gerrit-Change-Number: 34471 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
