Attention is currently required from: dexter, osmith, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/34471?usp=email )

Change subject: abis_nm: delay configure_loop() until NM_MT_SW_ACTIVATED_REP
......................................................................


Patch Set 2:

(3 comments)

This change is ready for review.

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/34471/comment/80c1ce50_c327b0cf
PS1, Line 42: plus for the ip.access
            : specific MOs
> Oh, I actually forgot to update those MOs: GPRS Cell, GPRS NSE, and GPRS NSVC.
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/34471/comment/a1fced89_832578fd
PS1, Line 51: expected to fix
> Expected but does not (as can be seen from a recent PCAP provided by @pespin).
Removed this statement.


File src/osmo-bsc/nm_bb_transc_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34471/comment/e5d4c82c_85070e78
PS1, Line 116:  /* nanoBTS only: delay until SW Activated Report is received */
> Ack, I'll update this patch soon.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34471?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3953a5e41eb27165f9ff203cac7447ee9d311abf
Gerrit-Change-Number: 34471
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Sat, 23 Sep 2023 10:59:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to