Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email )
Change subject: PCUIF_Components: ensure clean IMSI string ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think a better solution would be changing the definition of `record PCUIF_pch` and letting the RAW encoder do the magic for us. Can you try changing `variant (imsi) "FIELDLENGTH(17)"` to `variant (imsi) "FIELDLENGTH(null_terminated)"`, like it's already done for the `PCUIF_Text`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224 Gerrit-Change-Number: 34498 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
