Attention is currently required from: fixeria.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email )

Change subject: PCUIF_Components: ensure clean IMSI string
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> I think a better solution would be changing the definition of `record 
> PCUIF_pch` and letting the RAW […]
Now I get: "262420000000423" & char(0, 0, 0, 0) & char(0, 0, 0, 241), which 
causes even more odd behavior. I also have no clue where the char(0, 0, 0, 241) 
comes from. Before it was at least "262420000000423" & char(0, 0, 0, 0) & 
char(0, 0, 0, 0)

The definition is currently as follows:
type record PCUIF_pch {
        OCT4            msg_id,
        charstring      imsi length(17),
        octetstring     data length(23),
        boolean         confirm
} with {
        variant (msg_id) "BYTEORDER(last)"
        variant (imsi) "FIELDLENGTH(null_terminated)"
        variant (data) "FIELDLENGTH(23)"
};

I will try it again tomorrow and experiment a bit. Unfortunately the Regex was 
the best I could come up with.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34498?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7bfea59a306e75211856e4e80985ebf000c42224
Gerrit-Change-Number: 34498
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 21 Sep 2023 17:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to