Attention is currently required from: laforge, lynxis lazus. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34884?usp=email )
Change subject: pySim-shell: don't get trapped in applications without file system ...................................................................... Patch Set 2: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/34884/comment/e371d6fe_e4a0b750 PS2, Line 620: "a0000000871002", "a0000000871004"]: > I like the approach in general, but I think we shouldn't open-code those AIDs > explicitly here. […] I have now changed the code so that it does no longer use the hardcoded identifiers. Also not "ADF.USIM" or "ADF.ISIM". (I still need to add ADF.HPSIM) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fdd65f430c07acb1afdaf265d24c6928b654e0 Gerrit-Change-Number: 34884 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Wed, 25 Oct 2023 15:08:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
