Attention is currently required from: fixeria, laforge, lynxis lazus. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34884?usp=email )
Change subject: pySim-shell: don't get trapped in applications without file system ...................................................................... Patch Set 5: (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/34884/comment/59d91d78_7a62dabf PS4, Line 66: from pySim.ts_31_102 import ADF_USIM : from pySi > you're importing but not using these? Those are from my previous approach, they are indeed not used anymore. https://gerrit.osmocom.org/c/pysim/+/34884/comment/89fd61a3_4ad90555 PS4, Line 605: parent = self._cmd.lchan.selected_file.get_selectables()[".."] > may be worth moving this into a separate function, to improve readability We can just use the .parent property of the file (I didn't see that at first). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fdd65f430c07acb1afdaf265d24c6928b654e0 Gerrit-Change-Number: 34884 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 04 Dec 2023 12:27:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
