Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35205?usp=email )
Change subject: IuUP: always allow Initialization ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/35205/comment/edfd6c62_3b3777df PS1, Line 28: Decided for now that it's not worth the extra effort to make this more : restrictive I would beg to differ. It is opening up the chance for all kinds of bugs if 'random' packets are permitted here. IMHO we should be rather restrictive in what we permit. I even don't like the general idea of having to accept packets from "anywhere". But from your commit log it seems like this is mandatory to achieve a working solution. In that case we should further constrain what is an accepted packet (and in which state we do so), as you describe below. Doesn't have to be neccessarily in this patch, but IMHO should be following up immediately. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6c365559a7bd197349f0ea99f7a13b56a4bb580b Gerrit-Change-Number: 35205 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Mon, 04 Dec 2023 08:58:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
