Attention is currently required from: neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/35205?usp=email )

Change subject: IuUP: always allow Initialization
......................................................................


Patch Set 1:

(1 comment)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35205/comment/879ad80e_a2c4708f
PS1, Line 838:  if (mgcp_conn_rtp_is_iuup(conn) && !conn->iuup.configured) {
I see a problem with this, regarding SYS#6657. In osmo-hnbgw I changed 
libosmo-mgcp-client to output MGCP CRCX with an ip addr but without port or 
codec info, which means the MGW doesn't know yet that the endpoint will handle 
IuUP and hence this will return false.

Maybe I'd need to submit codec IuFP codec with port=0 in libosmo-mgcp-client 
during CRCX instead so that MGW already configured the endpoint conn as IuUP 
during CRCX instead of delaying the upgrade until MDCX.

This means turning this patch below from version 2 to its earlier version 1: 
https://gerrit.osmocom.org/c/osmo-mgw/+/35152/1..2/src/libosmo-mgcp-client/mgcp_client.c



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35205?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6c365559a7bd197349f0ea99f7a13b56a4bb580b
Gerrit-Change-Number: 35205
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Mon, 04 Dec 2023 10:34:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to