Attention is currently required from: dexter, laforge, neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email )

Change subject: ecu: force alignment of member data in struct osmo_ecu_state
......................................................................


Patch Set 5:

(1 comment)

File src/codec/ecu_fr.c:

https://gerrit.osmocom.org/c/libosmocore/+/35212/comment/0c05db7d_26f3d94b
PS5, Line 315:  struct fr_ecu_state *fr = (struct fr_ecu_state *) st;
Here and in the function below is where you need container_of:

    static inline struct fr_ecu_state *_osmo_ecu_state_get_fr(struct 
osmo_ecu_state *st) {
            return (struct fr_ecu_state *)container_of(st, struct fr_ecu_state, 
ecu_state);
    }

    static int ecu_fr_frame_out(struct osmo_ecu_state *st, uint8_t *frame_out)
    {
            struct fr_ecu_state *fr = _osmo_ecu_state_get_fr(st);
            ....



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I28672856e8e8f47e04ffe09ee3e07b577108cdc7
Gerrit-Change-Number: 35212
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 14 Dec 2023 12:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to