Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email )
Change subject: gtp-link: add IPv6 support ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/e664e1e3_44694f55 PS1, Line 12: ./gtp-link add gtp0 ip # IPv4 GGSN It would be great that while doing this we take into account that we will want to specify an outer IPv4/IPv6 address instead of currently used ANY_ADDR. https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/fefd0643_efc751d8 PS1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN Also, afaiu it should be possible to have one tunnel bind to both an IPv4 and an IPv6 address, and depending on the IP address provided by the peer, use one or another when sharing messages. (see GTPv1C/GTPv2C where it's possible to signal both an IPv4 and IPv6 address to the peer). File tools/gtp-link.c: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/ddd91078_734aef7d PS1, Line 159: ret = gtp_dev_create(-1, argv[2], gtp_sock.fd1, gtp_sock.fd2); I'd welcome if we could rename this fd1 and fd2 to fd0 and fd1u to name which proto are they used for (no need to do it in this same patch). -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I201c32a1bf9a2ab7a228287590bc7ec19c4997b9 Gerrit-Change-Number: 35985 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Thu, 15 Feb 2024 14:57:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
