Attention is currently required from: osmith, pablo, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email )
Change subject: gtp-link: add IPv6 support ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/2de81325_439ca80f PS1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN > I have extended the gtp-link stub to allow to take an optional listener > address to show that this is […] out of scope for this current project/task, but for @[email protected] benefit: There was some brainstorming about de-coupling the 1:1 mapping between UDP socket and net-device in https://osmocom.org/issues/6103 File tools/gtp-link.c: https://gerrit.osmocom.org/c/libgtpnl/+/35985/comment/2f149c20_41fae29d PS1, Line 159: ret = gtp_dev_create(-1, argv[2], gtp_sock.fd1, gtp_sock.fd2); > I'm fine with that readibility cleanup Done -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I201c32a1bf9a2ab7a228287590bc7ec19c4997b9 Gerrit-Change-Number: 35985 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pablo <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pablo <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 16 Feb 2024 12:41:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pablo <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
