Patch Set 2: Code-Review+2 (1 comment)
I have reservations but if this fixes the build... you decide https://gerrit.osmocom.org/#/c/5777/2/tests/test_py3.py File tests/test_py3.py: Line 8: # from ..osmopy.osmo_ipa import Ctrl In osmo-gsm-tester we use 'from . import foo'. Also possible could be a symlink ln -s ../osmopy . which would allow 'from osmopy', as we use in the scripts/ subdir. Also possible would be invoking the script with a PYTHONPATH env variable set. I'd prefer either of those to mangling the python path ... I know I also did that some while back in some vty tests py scripts in openbsc.git IIRC, but I didn't know better back then. -- To view, visit https://gerrit.osmocom.org/5777 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ac3c0d45fb2e1d18646048703ac405be1c7e539 Gerrit-PatchSet: 2 Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
