Patch Set 2:

> In osmo-gsm-tester we use 'from . import foo'.

That won't work because tests are in separate subdirectory so we should go one 
level up.

> possible could be a symlink

I'd rather keep it in one single place next to comment with explanation.

> with a PYTHONPATH env variable set

I think this is discouraged. Also see previous comment.

> I'd prefer either of those to mangling the python path

I'd prefer to make "from ..osmopy" working but let's first fix the immediate 
problem at hand and do "nice to have" things later on.

-- 
To view, visit https://gerrit.osmocom.org/5777
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ac3c0d45fb2e1d18646048703ac405be1c7e539
Gerrit-PatchSet: 2
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-HasComments: No

Reply via email to