Attention is currently required from: laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email )

Change subject: osmo_io: Add osmo_io_get_ioops() function
......................................................................


Patch Set 1:

(1 comment)

File include/osmocom/core/osmo_io.h:

https://gerrit.osmocom.org/c/libosmocore/+/36076/comment/fb97b828_fd806e90
PS1, Line 112: void osmo_iofd_get_ioops(struct osmo_io_fd *iofd, struct 
osmo_io_ops *ioops);
> If you want to make it generic, it would probably be best to decoupple the 
> segmentation callback fro […]
Yeah well you can even do address calculation to change stuff even if you don't 
get the pointer, but that's not the point :P

Fine, let's keep it this way then if it's good enough for whoever is writing 
the API.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I03398c811b9534f50c6644b21eea89a04be29fb0
Gerrit-Change-Number: 36076
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Wed, 28 Feb 2024 13:02:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to