Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/36575?usp=email )

Change subject: ss7_asp: Update osmo_stream read_cb2 functions to accommodate 
for new API param
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

File src/osmo_ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/36575/comment/d6329ab0_00d3cf79
PS6, Line 1050: if (res < 0) {
              :                 xua_cli_close_and_reconnect(conn);
              :                 goto out;
              :         } else if (res == 0) {
              :                 xua_cli_close_and_reconnect(conn);
              :
              :                 goto out;
              :         }
could be changed to "if (res <= 0)"



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36575?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I579f4101a9e2874e310ff78e4571f38cfe8dfab0
Gerrit-Change-Number: 36575
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 18 Apr 2024 09:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to