Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36575?usp=email )
Change subject: ss7_asp: Update osmo_stream read_cb2 functions to accommodate for new API param ...................................................................... Patch Set 6: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/36575/comment/e8ab38b5_1a8636d7 PS6, Line 1050: if (res < 0) { : xua_cli_close_and_reconnect(conn); : goto out; : } else if (res == 0) { : xua_cli_close_and_reconnect(conn); : : goto out; : } > could be changed to "if (res <= 0)" Yes I know but I wanted to keep the two conditions separated in general, one for regular socket close and other one for errors. Makes it easier to extend later if neeeded. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I579f4101a9e2874e310ff78e4571f38cfe8dfab0 Gerrit-Change-Number: 36575 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 18 Apr 2024 09:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Gerrit-MessageType: comment
