Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )
Change subject: HTTP_Adapter: allow API users to specifiy custom header ...................................................................... Patch Set 2: (4 comments) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/a703254b_c50d7499 PS1, Line 41: function ts_HTTP_Header(template charstring body := omit, > I'd prefer having this one prefixed "f_ts_", since it's actually a function. > […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/c033169a_48c0c19c PS1, Line 42: template charstring host := omit, > template (omit) charstring Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/2752abad_bcf7364b PS1, Line 55: if (ispresent(body)) { > I'm not sure ispresent() can be used this way, or only for optional fields in > a record. […] I have verified that it works with ispresent(), but if (not istemplatekind(body, "omit")) also works. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/05a2da73_5e253896 PS1, Line 59: /* Add custom header lines, already existing headers (name) are updated */ > I think it makes sense to move this to a separate function "merge_headers()" > or "overlay_headers()". […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57 Gerrit-Change-Number: 36504 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2024 11:55:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
