Attention is currently required from: dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )

Change subject: HTTP_Adapter: allow API users to specifiy custom header
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

File library/HTTP_Adapter.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/efa2dddb_8ad3cd12
PS2, Line 72:           hdr := hdr & {{ header_name := "Host", header_value := 
valueof(host) }};
hint: I usually find it way more readable to use templates instead of filling 
records, eg:
   hdr := hdr & { ts_Header("Host", host) };



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I115fd14254e0957c0955649aeb47059dc180bf57
Gerrit-Change-Number: 36504
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Fri, 19 Apr 2024 13:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to