Attention is currently required from: lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email )

Change subject: docs: add basic manual of the osmo-epdg
......................................................................


Patch Set 2:

(10 comments)

File docs/manuals/chapters/epcrequirements.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/f775bb18_e8b7bbf0
PS2, Line 14: An UE will request attributes via IKEv2 which are translated into 
additional PCO in GTP on the S2b
Additional PCO (APCO)


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/65893856_906a002a
PS2, Line 15: reference point. THe PGW should support additional PCO via S2b.
Additional PCO


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/b585c145_0cd234a0
PS2, Line 16: open5gs supports additional PCO by 2.7.1.
Additional PCO since v2.7.1


File docs/manuals/chapters/osmo-epdg.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/e520aea9_1a2a4c19
PS2, Line 16: For Debian based distribution osmocom provides packages 
repositories:
package repositories


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/84e29a8d_b09c7912
PS2, Line 29: ===== CEIA: Connection for strongSwan
I recall this was usually CEAI? whatever it's meaning is :)


File docs/manuals/chapters/overview.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/7755c924_64b9d17a
PS2, Line 27: Further the osmo-epdg is using strongSwan to handle the 
communication towards UEs.
"Furthermore, osmo-epdg speaks with strongswan to handle communication..." ?


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/5a7256c5_d1652f79
PS2, Line 34: * Linux generic policy routing and firewall (user plane)
I think we are missing mention to the gtp kernel module somewhere in here.


File docs/manuals/chapters/strongswan.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/db65ba9c_64c8e356
PS2, Line 8: strongSwan has been extended to support this role in the osmo-epdg.
this means it was forked, so information on where to find it should be provided 
here.


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/18f3aa1e_7ccf945f
PS2, Line 44: Further it allows the osmo-epdg/erlang to:
Moreover? I don't think you can use Further this way; I may be wrong though.


File docs/manuals/ue-connects.msc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/f7bc7b8d_b3574f72
PS2, Line 8:  
> trailing whitespace

Please fix.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b
Gerrit-Change-Number: 36783
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Mon, 13 May 2024 09:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to