Attention is currently required from: pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email )

Change subject: docs: add basic manual of the osmo-epdg
......................................................................


Patch Set 3:

(10 comments)

File docs/manuals/chapters/epcrequirements.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/90bd2154_1b342bb3
PS2, Line 14: An UE will request attributes via IKEv2 which are translated into 
additional PCO in GTP on the S2b
> Additional PCO (APCO)
Done


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/77c0b703_c97ba6bf
PS2, Line 15: reference point. THe PGW should support additional PCO via S2b.
> Additional PCO
Done


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/0b9a16c4_b573c2a1
PS2, Line 16: open5gs supports additional PCO by 2.7.1.
> Additional PCO since v2.7. […]
Done


File docs/manuals/chapters/osmo-epdg.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/cdf4ab09_287c5747
PS2, Line 16: For Debian based distribution osmocom provides packages 
repositories:
> package repositories
Done


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/e8fac7ed_31f16339
PS2, Line 29: ===== CEIA: Connection for strongSwan
> I recall this was usually CEAI? whatever it's meaning is :)
Done


File docs/manuals/chapters/overview.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/b9824bd1_a68e200b
PS2, Line 27: Further the osmo-epdg is using strongSwan to handle the 
communication towards UEs.
> "Furthermore, osmo-epdg speaks with strongswan to handle communication... […]
Done


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/a946366e_3462302b
PS2, Line 34: * Linux generic policy routing and firewall (user plane)
> I think we are missing mention to the gtp kernel module somewhere in here.
Done


File docs/manuals/chapters/strongswan.adoc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/9c930e31_2b8fb620
PS2, Line 8: strongSwan has been extended to support this role in the osmo-epdg.
> this means it was forked, so information on where to find it should be 
> provided here.
Done


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/646e93d9_f249d602
PS2, Line 44: Further it allows the osmo-epdg/erlang to:
> Moreover? I don't think you can use Further this way; I may be wrong though.
Done


File docs/manuals/ue-connects.msc:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/c30d2532_904a994e
PS2, Line 8:
> > trailing whitespace […]
Done



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b
Gerrit-Change-Number: 36783
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 14 May 2024 14:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to